drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kamesh B" <kamesh.had...@gmail.com>
Subject Re: Review Request 30313: Fixing Mongo join issue when * is selected
Date Fri, 27 Feb 2015 04:37:12 GMT


> On Feb. 27, 2015, 12:19 a.m., Hanifi Gunes wrote:
> > contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/MongoRecordReader.java,
line 200
> > <https://reviews.apache.org/r/30313/diff/1/?file=836234#file836234line200>
> >
> >     This does not seem quite right to me. What if multiple writes fail? Also note
that this will change the order of records being written into vectors.

The reason for doing this is, if there is any issue while storing documents into value vectors,
and if the vectors don't have any buffers, if fails to write it. But by that time, Mongo iterator
advances its iterator. When the flow again reaches to next method, first we need to process
the previously read document, otherwise, we will miss that document.
But, I think, with DRILL-1960, we may not encounter this scenario. 

Will update the patch.


- Kamesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30313/#review74406
-----------------------------------------------------------


On Jan. 27, 2015, 10:27 a.m., Kamesh B wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30313/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2015, 10:27 a.m.)
> 
> 
> Review request for drill, Jacques Nadeau and Jinfeng Ni.
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> Fixing Mongo join issue when * is selected.
> 
> 
> Diffs
> -----
> 
>   contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/MongoRecordReader.java
4b7360057e9d95fb0176b035469bca02128a0b34 
> 
> Diff: https://reviews.apache.org/r/30313/diff/
> 
> 
> Testing
> -------
> 
> Tested the patch by selecting * in join operation. It is working fine. This patch also
fixes some of issues caused by earlier commits.
> 
> 
> Thanks,
> 
> Kamesh B
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message