drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Barclay" <dbarc...@maprtech.com>
Subject Re: Review Request 31419: DRILL-1378: Ctrl-C to cancel a query that has not returned with the first result set
Date Wed, 25 Feb 2015 20:05:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31419/#review74081
-----------------------------------------------------------



exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillResultSet.java
<https://reviews.apache.org/r/31419/#comment120588>

    Yeah, I just noticed that NullPointerException case a couple of days ago.



exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillResultSet.java
<https://reviews.apache.org/r/31419/#comment120589>

    Should/can this be a call to releaseIfFirst() rather than directly calling latch.countDown()?


- Daniel Barclay


On Feb. 25, 2015, 6:38 p.m., Parth Chandra wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31419/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2015, 6:38 p.m.)
> 
> 
> Review request for drill, Daniel Barclay, Hanifi Gunes, and Mehant Baid.
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> Sqlline hangs when you try to cancel the query before the first result set has been returned.
> 
> 
> Diffs
> -----
> 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillResultSet.java 88a6c6d 
> 
> Diff: https://reviews.apache.org/r/31419/diff/
> 
> 
> Testing
> -------
> 
> Tested with a query that takes a long time to return the first result set. Ctrl-C to
exit the query. This fix simply addresses the hang. It does not fix Avatica to display cancellation
in a nicer manner. Also, have not verified that the query cancellation occurs on the drillbit
in all cases (waiting for DRILL-2245)
> 
> 
> Thanks,
> 
> Parth Chandra
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message