drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Barclay" <dbarc...@maprtech.com>
Subject Review Request 31399: DRILL-2130: Fixed JUnit/Hamcrest/Mockito/Paranamer class path problem.
Date Wed, 25 Feb 2015 06:52:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31399/
-----------------------------------------------------------

Review request for drill, Aditya Kishore and Jason Altekruse.


Repository: drill-git


Description
-------

Main change:  In exec/java-exec/pom.xml, suppressed Paranamer's transitive dependency on Mockito
and the Hamcrest files bundled in it, and put JUnit and thereby Hamcrest on classpath before
Mockito.

NOTE:  Please review placement (and details) of the added <dependency.../> elements.
 The current placement seems to work, but probably doesn't follow our intendent Maven patterns.


Other change:  Added tests to detect regression (or confirm other solutions to problem).


Diffs
-----

  common/src/test/java/org/apache/drill/test/Drill2130CommonHamcrestConfigurationTest.java
PRE-CREATION 
  contrib/storage-hbase/src/test/java/org/apache/drill/hbase/test/Drill2130StorageHBaseHamcrestConfigurationTest.java
PRE-CREATION 
  contrib/storage-hive/core/src/test/java/org/apache/drill/exec/test/Drill2130StorageHiveCoreHamcrestConfigurationTest.java
PRE-CREATION 
  exec/interpreter/src/test/java/org/apache/drill/exec/expr/test/Drill2130InterpreterHamcrestConfigurationTest.java
PRE-CREATION 
  exec/java-exec/pom.xml 06f60fb 
  exec/java-exec/src/test/java/org/apache/drill/exec/test/Drill2130JavaExecHamcrestConfigurationTest.java
PRE-CREATION 
  exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Drill2130JavaJdbcHamcrestConfigurationTest.java
PRE-CREATION 

Diff: https://reviews.apache.org/r/31399/diff/


Testing
-------

Ran new and existing tests.


Thanks,

Daniel Barclay


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message