drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Barclay" <dbarc...@maprtech.com>
Subject Review Request 31319: DRILL-2283: Fixed: INFORMATION_SCHEMA strings were VARCHAR(1), breaking comparison
Date Mon, 23 Feb 2015 21:25:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31319/
-----------------------------------------------------------

Review request for drill, Mehant Baid and Parth Chandra.


Bugs: DRILL-2283
    https://issues.apache.org/jira/browse/DRILL-2283


Repository: drill-git


Description
-------

Fixed implementation string columns of INFORMATION SCHEMA tables from calling method that
set type to VARCHAR(1) to setting type to VARCHAR(<some large-enough value>).


Diffs
-----

  exec/java-exec/src/main/java/org/apache/drill/exec/store/ischema/InfoSchemaTable.java c343c5c

  exec/java-exec/src/test/java/org/apache/drill/exec/store/ischema/Drill2283InfoSchemaVarchar1BugTest.java
PRE-CREATION 

Diff: https://reviews.apache.org/r/31319/diff/


Testing
-------

Ran new specific unit tests and existing test suites.


Thanks,

Daniel Barclay


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message