drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jinfeng Ni" <...@maprtech.com>
Subject Re: Review Request 27711: To fix DRILL-1062, honoring "NULLS FIRST" and "NULLS LAST"
Date Sat, 21 Feb 2015 02:42:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27711/#review73388
-----------------------------------------------------------

Ship it!


The new patches look good to me.

- Jinfeng Ni


On Feb. 19, 2015, 1:28 p.m., Daniel Barclay wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27711/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2015, 1:28 p.m.)
> 
> 
> Review request for drill, Jinfeng Ni and Mehant Baid.
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> DRILL-1062:  Implemented null ordering (NULLS FIRST/NULLS LAST).
> 
> Primary:  
> - Split "compare_to" function templates (for sorting) into 
>   "compare_to_nulls_high" and "compare_to_nulls_low" versions.
> - Added tests to verify ORDER BY ordering.
> - Added tests to verify merge join order correctness.
> - Implemented java.sql.DatabaseMetaData.nullsAreSortedHigh(), etc.
> 
> Secondary:
> - Eliminated DateInterfaceFunctions.java template (merged into other).
> - Renamed comparison-related template data objects and file names.
> - Eliminated unused template macros, function template classes.
> - Overhauled Order.Ordering; added unit test.
> - Regularized some generated-class names.
> 
> Miscellaneous:
> - Added toString() to ExpressionPosition, Order.Ordering, JoinStatus.
> - Fixed some typos.
> - Fixed some comment syntax.
> 
> 
> Diffs
> -----
> 
>   .gitignore 838ea6b 
>   common/src/main/java/org/apache/drill/common/expression/ExpressionPosition.java 010e440

>   common/src/main/java/org/apache/drill/common/expression/fn/CastFunctions.java f1a3b37

>   common/src/main/java/org/apache/drill/common/logical/data/Order.java dada606 
>   common/src/test/java/org/apache/drill/common/logical/data/OrderTest.java PRE-CREATION

>   contrib/storage-hive/core/src/test/java/org/apache/drill/exec/TestHiveProjectPushDown.java
0246f54 
>   exec/java-exec/src/main/codegen/config.fmpp aff6240 
>   exec/java-exec/src/main/codegen/data/CompareTypes.tdd f384d52 
>   exec/java-exec/src/main/codegen/data/ComparisonTypesDecimal.tdd PRE-CREATION 
>   exec/java-exec/src/main/codegen/data/ComparisonTypesMain.tdd PRE-CREATION 
>   exec/java-exec/src/main/codegen/data/DateTypes.tdd 5802df0 
>   exec/java-exec/src/main/codegen/data/DecimalTypes.tdd 423fe89 
>   exec/java-exec/src/main/codegen/templates/ComparisonFunctions.java 628277c 
>   exec/java-exec/src/main/codegen/templates/DateIntervalFunctions.java 8fe13bb 
>   exec/java-exec/src/main/codegen/templates/Decimal/CastVarCharDecimal.java 960368a 
>   exec/java-exec/src/main/codegen/templates/Decimal/DecimalFunctions.java 0c4af01 
>   exec/java-exec/src/main/java/org/apache/drill/exec/client/PrintingResultsListener.java
1ed3cb3 
>   exec/java-exec/src/main/java/org/apache/drill/exec/expr/ExpressionTreeMaterializer.java
e1ad854 
>   exec/java-exec/src/main/java/org/apache/drill/exec/expr/annotations/FunctionTemplate.java
1f732a3 
>   exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/FunctionGenerationHelper.java
d007d7c 
>   exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/FunctionImplementationRegistry.java
25dcbbc 
>   exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/BitFunctions.java 3fe489f

>   exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/ComparisonFunctions.java
bf42ce6 
>   exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/ComparisonFunctionsNullable.java
570aaeb 
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/TopN/TopNBatch.java
9829fc6 
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/StreamingAggBatch.java
860627d 
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/common/ChainedHashTable.java
ea19645 
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinStatus.java
a7fa5aa 
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinTemplate.java
48a0996 
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/MergeJoinBatch.java
257b93e 
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/mergereceiver/MergingRecordBatch.java
d78ba8e 
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/orderedpartitioner/OrderedPartitionRecordBatch.java
a062074 
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/sort/SortBatch.java
19f5423 
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/window/StreamingWindowFrameRecordBatch.java
26d23f2 
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/ExternalSortBatch.java
9026661 
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/MSorter.java
e80d309 
>   exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/ProjectPrule.java
6d26419 
>   exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/QueryResultHandler.java
9015a16 
>   exec/java-exec/src/test/java/org/apache/drill/TestAggNullable.java 4c9617b 
>   exec/java-exec/src/test/java/org/apache/drill/TestExampleQueries.java 9d3b8dc 
>   exec/java-exec/src/test/java/org/apache/drill/TestInList.java 03fbf97 
>   exec/java-exec/src/test/java/org/apache/drill/TestJoinNullable.java c49da6c 
>   exec/java-exec/src/test/resources/jsoninput/nullableOrdered1.json PRE-CREATION 
>   exec/java-exec/src/test/resources/jsoninput/nullableOrdered2.json PRE-CREATION 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillDatabaseMetaData.java PRE-CREATION

>   exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillFactory.java 9b9eb7b 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillJdbc41Factory.java 7fb0a34 
>   exec/jdbc/src/test/java/org/apache/drill/jdbc/test/JdbcNullOrderingAndGroupingTest.java
PRE-CREATION 
>   exec/jdbc/src/test/resources/donuts.json PRE-CREATION 
>   exec/jdbc/src/test/resources/null_ordering_and_grouping_data.json PRE-CREATION 
>   pom.xml 7f973c8 
> 
> Diff: https://reviews.apache.org/r/27711/diff/
> 
> 
> Testing
> -------
> 
> Ran new fix-specific unit tests, existing tests.
> 
> 
> Thanks,
> 
> Daniel Barclay
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message