drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Parth Chandra" <pchan...@maprtech.com>
Subject Review Request 31200: DRILL-2197: Fix no applicable constructor error in outer join with a map type
Date Thu, 19 Feb 2015 19:22:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31200/
-----------------------------------------------------------

Review request for drill, Hanifi Gunes and Mehant Baid.


Repository: drill-git


Description
-------

Problem occurs because the left join requires the output type of the columns to be nullable
and map types are not nullable. So the TypeHelper class creates a default type (in this cas
NullableTinyInt) and that cause the runtime generated code to not compile.


Diffs
-----

  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java
dae8a03 
  exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/TestJoinComplex.java
PRE-CREATION 
  exec/java-exec/src/test/resources/join/DRILL-2197-result-1.json PRE-CREATION 
  exec/java-exec/src/test/resources/join/DRILL-2197-result-2.json PRE-CREATION 
  exec/java-exec/src/test/resources/join/complex_1.json PRE-CREATION 
  exec/java-exec/src/test/resources/join/complex_2.json PRE-CREATION 

Diff: https://reviews.apache.org/r/31200/diff/


Testing
-------

Added new units tests for left join queries returning a map type.


Thanks,

Parth Chandra


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message