drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aman Sinha" <asi...@maprtech.com>
Subject Re: Review Request 30959: DRILL-2236: Optimize hash inner join by swapping inputs based on row count comparison.
Date Sat, 14 Feb 2015 00:18:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30959/#review72460
-----------------------------------------------------------



exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/HashJoinPrel.java
<https://reviews.apache.org/r/30959/#comment118527>

    I think swapped should be set to true here such that the join knows that the inputs have
been swapped if it is visited again.



exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/SwapHashJoinVisitor.java
<https://reviews.apache.org/r/30959/#comment118530>

    This visitor is top-down; I was also thinking what the advantages/disadvantages are for
a bottom-up approach to swapping the inputs. The output cardinality of a join node does not
change in either approach but perhaps we should think a little bit about the other approach
as well.


- Aman Sinha


On Feb. 13, 2015, 1:10 a.m., Jinfeng Ni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30959/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2015, 1:10 a.m.)
> 
> 
> Review request for drill.
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> See https://issues.apache.org/jira/browse/DRILL-2236#.
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/HashJoinPrel.java
a3c42de 
>   exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/JoinPrel.java 3541db7

>   exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/MergeJoinPrel.java
394a82c 
>   exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/PlannerSettings.java
faa8546 
>   exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/explain/NumberingRelWriter.java
6522ad9 
>   exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/SwapHashJoinVisitor.java
PRE-CREATION 
>   exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DefaultSqlHandler.java
6b3d301 
>   exec/java-exec/src/main/java/org/apache/drill/exec/server/options/SystemOptionManager.java
aa0a5ad 
> 
> Diff: https://reviews.apache.org/r/30959/diff/
> 
> 
> Testing
> -------
> 
> Unit test done. 
> 
> Other regression workloads are running. Will update status once complete.
> 
> 
> Thanks,
> 
> Jinfeng Ni
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message