drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Hsuan-Yi Chu" <hsua...@usc.edu>
Subject Re: Review Request 30771: DRILL-1977: Wrong result with aggregation on top of UNION ALL operator
Date Mon, 09 Feb 2015 21:06:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30771/
-----------------------------------------------------------

(Updated Feb. 9, 2015, 9:06 p.m.)


Review request for drill and Jinfeng Ni.


Bugs: DRILL-1977
    https://issues.apache.org/jira/browse/DRILL-1977


Repository: drill-git


Description
-------

Prevent records from being missing when groupby applied on top of union (see TestExampleQueries)


Diffs
-----

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/ProjectBelowHashAggVisitor.java
PRE-CREATION 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DefaultSqlHandler.java
79603eb 
  exec/java-exec/src/test/java/org/apache/drill/TestExampleQueries.java dffa0a6 
  exec/java-exec/src/test/resources/store/text/data/t.json PRE-CREATION 
  exec/java-exec/src/test/resources/testframework/testExampleQueries/testAggregationOnUnionAllOperator/q1.tsv
PRE-CREATION 
  exec/java-exec/src/test/resources/testframework/testExampleQueries/testAggregationOnUnionAllOperator/q2.tsv
PRE-CREATION 

Diff: https://reviews.apache.org/r/30771/diff/


Testing
-------

unit, tpch (# 729), functional (#493) tests passed


Thanks,

Sean Hsuan-Yi Chu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message