drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Westin" <chriswesti...@gmail.com>
Subject Re: Review Request 30593: DRILL-2151: VariableLengthVector.copyFromSafe() unnecessary sets the offsetVector
Date Wed, 04 Feb 2015 19:50:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30593/#review71025
-----------------------------------------------------------

Ship it!


Ship It!

- Chris Westin


On Feb. 4, 2015, 8:42 a.m., abdelhakim deneche wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30593/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2015, 8:42 a.m.)
> 
> 
> Review request for drill.
> 
> 
> Bugs: DRILL-2151
>     https://issues.apache.org/jira/browse/DRILL-2151
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> emoved the line
> 
>     offsetVector.getMutator().setSafe( (thisIndex+1) * ${type.width}, outputStart + len);
> 
> from *VariableLengthVector.copyFromSafe()*
> 
> and refactored the call to *from.offsetVector.getAccessor()* to reuse the result.
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/codegen/templates/VariableLengthVectors.java aa5b702 
> 
> Diff: https://reviews.apache.org/r/30593/diff/
> 
> 
> Testing
> -------
> 
> all unit tests pass
> "Functional - Passing - new" passes on 171
> "Advanced TPCH SF100" passes on 57
> the query described in DRILL-2151 runs fine now
> 
> 
> Thanks,
> 
> abdelhakim deneche
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message