drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "abdelhakim deneche" <adene...@gmail.com>
Subject Review Request 30622: DRILL-1953: alter session set `store.json.all_text_mode` does not work as documented
Date Wed, 04 Feb 2015 16:48:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30622/
-----------------------------------------------------------

Review request for drill, Jacques Nadeau and Jason Altekruse.


Bugs: DRILL-1953
    https://issues.apache.org/jira/browse/DRILL-1953


Repository: drill-git


Description
-------

Setting *store.json.all_text_mode* on the *SESSION* level doesn't have any effect on *JSONRecordReader*

The same problem was found and fixed in *MongoRecordReader*


Diffs
-----

  contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/MongoRecordReader.java
4b73600 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/JSONRecordReader.java
0070d18 
  exec/java-exec/src/test/java/org/apache/drill/exec/store/json/TestJsonRecordReader.java
449f091 
  exec/java-exec/src/test/resources/jsoninput/big_numeric.json PRE-CREATION 

Diff: https://reviews.apache.org/r/30622/diff/


Testing
-------

added new unit test to test the fix
all unit tests pass
both *Functional* and *TPCH SF100* tests pass


Thanks,

abdelhakim deneche


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message