Return-Path: X-Original-To: apmail-drill-dev-archive@www.apache.org Delivered-To: apmail-drill-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 49703175AB for ; Tue, 20 Jan 2015 02:52:56 +0000 (UTC) Received: (qmail 97919 invoked by uid 500); 20 Jan 2015 02:52:53 -0000 Delivered-To: apmail-drill-dev-archive@drill.apache.org Received: (qmail 97858 invoked by uid 500); 20 Jan 2015 02:52:53 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 97846 invoked by uid 500); 20 Jan 2015 02:52:52 -0000 Delivered-To: apmail-incubator-drill-dev@incubator.apache.org Received: (qmail 97840 invoked by uid 99); 20 Jan 2015 02:52:52 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 20 Jan 2015 02:52:52 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 20C4F1D2C48; Tue, 20 Jan 2015 02:52:49 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8667185698425615394==" MIME-Version: 1.0 Subject: Re: Review Request 30059: Synchronized, cleaned up, and documented SendingAccountor. From: "Jacques Nadeau" To: "Jacques Nadeau" , "Jason Altekruse" Cc: "Daniel Barclay" , "drill" Date: Tue, 20 Jan 2015 02:52:49 -0000 Message-ID: <20150120025249.9401.26916@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Jacques Nadeau" X-ReviewGroup: drill-git X-ReviewRequest-URL: https://reviews.apache.org/r/30059/ X-Sender: "Jacques Nadeau" References: <20150120004501.9402.80669@reviews.apache.org> In-Reply-To: <20150120004501.9402.80669@reviews.apache.org> Reply-To: "Jacques Nadeau" X-ReviewRequest-Repository: drill-git --===============8667185698425615394== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30059/#review68685 ----------------------------------------------------------- exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/SendingAccountor.java Let's not change this everywhere. exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/SendingAccountor.java Synchronized is fine. You can remove comments. exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/SendingAccountor.java Yes, it should. - Jacques Nadeau On Jan. 20, 2015, 12:45 a.m., Daniel Barclay wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30059/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2015, 12:45 a.m.) > > > Review request for drill, Jacques Nadeau and Jason Altekruse. > > > Repository: drill-git > > > Description > ------- > > Technical change: Added "synchronized" to increment(). > > Other changes: Documentation and renaming for clarity. > > > Diffs > ----- > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/SendingAccountor.java 7af7b65 > > Diff: https://reviews.apache.org/r/30059/diff/ > > > Testing > ------- > > Ran developer and QA tests; got no errors other than errors that appear for master branch. > > > Thanks, > > Daniel Barclay > > --===============8667185698425615394==--