Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
Content-Type: multipart/alternative;
 boundary="===============4566250744622824518=="
MIME-Version: 1.0
Subject: Re: Review Request 29549: DRILL-1874: Text reader should allow
 treating empty fields as NULLs instead of empty string
From: "Sean Hsuan-Yi Chu" <hsuanyi@usc.edu>
To: "Aman Sinha" <asinha@maprtech.com>, "Jinfeng Ni" <jni@maprtech.com>
Cc: "Sean Hsuan-Yi Chu" <hsuanyi@usc.edu>,
 "drill" <drill-dev@incubator.apache.org>
Date: Sun, 04 Jan 2015 23:48:59 -0000
Message-ID: <20150104234859.26559.29304@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Sean Hsuan-Yi Chu" <noreply@reviews.apache.org>
References: <20150102233236.31225.36260@reviews.apache.org>
In-Reply-To: <20150102233236.31225.36260@reviews.apache.org>
Reply-To: "Sean Hsuan-Yi Chu" <hsuanyi@usc.edu>

--===============4566250744622824518==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On Jan. 2, 2015, 11:32 p.m., Jinfeng Ni wrote:
> > exec/java-exec/src/main/codegen/templates/CastSafeFunctions.java, line 50
> > <https://reviews.apache.org/r/29549/diff/1/?file=805817#file805817line50>
> >
> >     Will this new castSafe function work,if the input is not-nullable varchar (since you are using NullHandling.INTERNAL) ?

I add another template () to deal with non-nullable varchar input
=> CastSafeFromNullableFunctions.java is for Nullable  
=> CastSafeFromNonnullableFunctions.java is for non-nullable


- Sean Hsuan-Yi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29549/#review66562
-----------------------------------------------------------


On Jan. 4, 2015, 11:46 p.m., Sean Hsuan-Yi Chu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29549/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2015, 11:46 p.m.)
> 
> 
> Review request for drill, Aman Sinha and Jinfeng Ni.
> 
> 
> Bugs: DRILL-1874
>     https://issues.apache.org/jira/browse/DRILL-1874
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> Users can choose to use safe (for varchar inputs)/default cast functions by setting sesseion variable ("alter session set `planner.safe_cast_varchar` = true;").
> 
> Add comments, Clean Codes
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/drill/common/expression/fn/CastFunctions.java 61d149d 
>   exec/java-exec/src/main/codegen/data/Casts.tdd 36c90c9 
>   exec/java-exec/src/main/codegen/templates/CastSafeFromNonnullableFunctions.java PRE-CREATION 
>   exec/java-exec/src/main/codegen/templates/CastSafeFromNullableFunctions.java PRE-CREATION 
>   exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java b390cd5 
>   exec/java-exec/src/main/java/org/apache/drill/exec/expr/ExpressionTreeMaterializer.java 0f40958 
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java fa983aa 
>   exec/java-exec/src/main/java/org/apache/drill/exec/server/options/SystemOptionManager.java 34729e2 
>   exec/java-exec/src/main/java/org/apache/drill/exec/store/text/DrillTextRecordReader.java e0cce8b 
> 
> Diff: https://reviews.apache.org/r/29549/diff/
> 
> 
> Testing
> -------
> 
> unit tests,
> functional tests,
> tpch tests
> 
> 
> Thanks,
> 
> Sean Hsuan-Yi Chu
> 
>


--===============4566250744622824518==--