Return-Path: X-Original-To: apmail-drill-dev-archive@www.apache.org Delivered-To: apmail-drill-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 24FE3100F1 for ; Sun, 4 Jan 2015 23:46:37 +0000 (UTC) Received: (qmail 4729 invoked by uid 500); 4 Jan 2015 23:46:37 -0000 Delivered-To: apmail-drill-dev-archive@drill.apache.org Received: (qmail 4671 invoked by uid 500); 4 Jan 2015 23:46:37 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 4658 invoked by uid 500); 4 Jan 2015 23:46:35 -0000 Delivered-To: apmail-incubator-drill-dev@incubator.apache.org Received: (qmail 4651 invoked by uid 99); 4 Jan 2015 23:46:35 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 04 Jan 2015 23:46:35 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 70FD91C9A45; Sun, 4 Jan 2015 23:46:33 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1196720612247745113==" MIME-Version: 1.0 Subject: Re: Review Request 29549: DRILL-1874: Text reader should allow treating empty fields as NULLs instead of empty string From: "Sean Hsuan-Yi Chu" To: "Aman Sinha" , "Jinfeng Ni" Cc: "Jacques Nadeau" , "drill" , "Sean Hsuan-Yi Chu" Date: Sun, 04 Jan 2015 23:46:33 -0000 Message-ID: <20150104234633.26559.46248@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Sean Hsuan-Yi Chu" X-ReviewGroup: drill-git X-ReviewRequest-URL: https://reviews.apache.org/r/29549/ X-Sender: "Sean Hsuan-Yi Chu" References: <20150102220956.31226.4900@reviews.apache.org> In-Reply-To: <20150102220956.31226.4900@reviews.apache.org> Reply-To: "Sean Hsuan-Yi Chu" X-ReviewRequest-Repository: drill-git --===============1196720612247745113== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29549/ ----------------------------------------------------------- (Updated Jan. 4, 2015, 11:46 p.m.) Review request for drill, Aman Sinha and Jinfeng Ni. Bugs: DRILL-1874 https://issues.apache.org/jira/browse/DRILL-1874 Repository: drill-git Description ------- Users can choose to use safe (for varchar inputs)/default cast functions by setting sesseion variable ("alter session set `planner.safe_cast_varchar` = true;"). Add comments, Clean Codes Diffs (updated) ----- common/src/main/java/org/apache/drill/common/expression/fn/CastFunctions.java 61d149d exec/java-exec/src/main/codegen/data/Casts.tdd 36c90c9 exec/java-exec/src/main/codegen/templates/CastSafeFromNonnullableFunctions.java PRE-CREATION exec/java-exec/src/main/codegen/templates/CastSafeFromNullableFunctions.java PRE-CREATION exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java b390cd5 exec/java-exec/src/main/java/org/apache/drill/exec/expr/ExpressionTreeMaterializer.java 0f40958 exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java fa983aa exec/java-exec/src/main/java/org/apache/drill/exec/server/options/SystemOptionManager.java 34729e2 exec/java-exec/src/main/java/org/apache/drill/exec/store/text/DrillTextRecordReader.java e0cce8b Diff: https://reviews.apache.org/r/29549/diff/ Testing ------- unit tests, functional tests, tpch tests Thanks, Sean Hsuan-Yi Chu --===============1196720612247745113==--