drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Barclay (Drill/MapR) (JIRA)" <j...@apache.org>
Subject [jira] [Created] (DRILL-2067) "Expected and actual text plans are different." errors don't include difference/plans
Date Fri, 23 Jan 2015 22:55:34 GMT
Daniel Barclay (Drill/MapR) created DRILL-2067:
--------------------------------------------------

             Summary: "Expected and actual text plans are different." errors don't include
difference/plans
                 Key: DRILL-2067
                 URL: https://issues.apache.org/jira/browse/DRILL-2067
             Project: Apache Drill
          Issue Type: Bug
            Reporter: Daniel Barclay (Drill/MapR)


In the test framework, when it reports:

bq. Expected and actual text plans are different.

it doesn't report the next-most-important piece of information--what the difference is.


More generally, we should pay more attention to usability or use cases of the tests.  

For example, in this case, think about what happens when a user (Drill developer) sees the
"Expected and actual text plans are different":  Frequently the user's first question will
be, "Well, what's the difference?"  

Therefore, the test framework should show that, at least by showing the expected and actual
values, giving the user enough information to find the difference his- or herself, without
having to, say, get a copy of the code, rebuild, and re-run in a debugger.






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message