drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Westin (JIRA)" <j...@apache.org>
Subject [jira] [Created] (DRILL-1925) inline static nested Accessor class methods
Date Sat, 03 Jan 2015 00:33:34 GMT
Chris Westin created DRILL-1925:
-----------------------------------

             Summary: inline static nested Accessor class methods
                 Key: DRILL-1925
                 URL: https://issues.apache.org/jira/browse/DRILL-1925
             Project: Apache Drill
          Issue Type: Improvement
          Components: Execution - Codegen
            Reporter: Chris Westin


Some scalar replacement opportunities had to be disabled because the holders' references are
passed in to static methods on nested Accessor classes as out parameters (their members are
filled in by the static methods). If we could inline those static methods (they generally
just seem to be 5-10 lines), then those holders could be replaced.

I thought the best option here would be to run something based on BasicInterpreter but which
would start a new interpreter for nested function calls, but which delegates to the containing
interpreter to emit the code. But I'm not sure how hard this will be to set up -- it will
require mapping through the transformations made to locals. And the interpreter calls are
very broad, covering many instructions each.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message