drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "abdelhakim deneche" <adene...@gmail.com>
Subject Re: Review Request 29643: DRILL-1970: Throw unsupported error message for window functions
Date Wed, 21 Jan 2015 16:10:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29643/
-----------------------------------------------------------

(Updated Jan. 21, 2015, 4:10 p.m.)


Review request for drill.


Summary (updated)
-----------------

DRILL-1970: Throw unsupported error message for window functions 


Bugs: DRILL-1970
    https://issues.apache.org/jira/browse/DRILL-1970


Repository: drill-git


Description
-------

display "Window functions have been disabled" when a query contains an over clause. But the
following issues still arise and throw different exceptions: DRILL-1863, DRILL-1862, DRILL-1852.
Those issues seem to be caused by optiq validation.


Diffs
-----

  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/window/StreamingWindowFrameBatchCreator.java
9b8929f 
  exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/window/TestWindowFrame.java
7c04477 

Diff: https://reviews.apache.org/r/29643/diff/


Testing
-------

All tests pass correctly.
Tested manually several queries with over clause and got "Window functions have been disabled"
message.


Thanks,

abdelhakim deneche


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message