drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hanifi Gunes" <hgu...@maprtech.com>
Subject Re: Review Request 29907: DRILL-2004: Foreman should account for fragment cancellations
Date Thu, 15 Jan 2015 22:33:04 GMT


> On Jan. 15, 2015, 9:18 p.m., Jacques Nadeau wrote:
> > exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/QueryManager.java,
line 61
> > <https://reviews.apache.org/r/29907/diff/1/?file=822064#file822064line61>
> >
> >     QueryManager should communicate to Foreman through the stateListener abstraction.
 It shouldn't hold a direct reference.

i used this for debugging not referenced. will remove.


> On Jan. 15, 2015, 9:18 p.m., Jacques Nadeau wrote:
> > exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentExecutor.java,
line 57
> > <https://reviews.apache.org/r/29907/diff/1/?file=822065#file822065line57>
> >
> >     ?

unused will remove.


> On Jan. 15, 2015, 9:18 p.m., Jacques Nadeau wrote:
> > exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentExecutor.java,
line 219
> > <https://reviews.apache.org/r/29907/diff/1/?file=822065#file822065line219>
> >
> >     This error message doesn't make sense in the method.

seems like a copy & paste problem. will fix.


> On Jan. 15, 2015, 9:18 p.m., Jacques Nadeau wrote:
> > exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentExecutor.java,
line 221
> > <https://reviews.apache.org/r/29907/diff/1/?file=822065#file822065line221>
> >
> >     Why runtimeexception?  Should be sublcass of drill exception

used the same code. will fix.


- Hanifi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29907/#review68311
-----------------------------------------------------------


On Jan. 15, 2015, 12:47 a.m., Hanifi Gunes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29907/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2015, 12:47 a.m.)
> 
> 
> Review request for drill, Jacques Nadeau, Parth Chandra, and Steven Phillips.
> 
> 
> Bugs: DRILL-2004
>     https://issues.apache.org/jira/browse/DRILL-2004
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> DRILL-2004: Foreman should account for early termination of fragments
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/WorkEventBus.java b9f0a26

>   exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java 5efc9fa

>   exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/QueryManager.java d4c87d4

>   exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentExecutor.java
27038d3 
> 
> Diff: https://reviews.apache.org/r/29907/diff/
> 
> 
> Testing
> -------
> 
> all tests pass
> 
> 
> Thanks,
> 
> Hanifi Gunes
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message