drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Hsuan-Yi Chu" <hsua...@usc.edu>
Subject Re: Review Request 29648: DRILL-1874: Text reader should allow treating empty fields as NULLs instead of empty string
Date Fri, 09 Jan 2015 00:14:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29648/
-----------------------------------------------------------

(Updated Jan. 9, 2015, 12:14 a.m.)


Review request for drill, Aman Sinha and Jinfeng Ni.


Bugs: DRILL-1874
    https://issues.apache.org/jira/browse/DRILL-1874


Repository: drill-git


Description
-------

Users can choose to use safe (for varchar inputs)/default cast functions by setting system
variable ("alter session set `planner.safe_cast_varchar` = true;").

Move the cast function replacement to "FunctionImplementationRegistry.java"

Add comments, Clean Codes


Diffs (updated)
-----

  common/src/main/java/org/apache/drill/common/expression/fn/CastFunctions.java 61d149d 
  exec/java-exec/src/main/codegen/data/Casts.tdd 36c90c9 
  exec/java-exec/src/main/codegen/templates/CastVarCharToNullableNumeric.java PRE-CREATION

  exec/java-exec/src/main/codegen/templates/Decimal/CastVarCharDecimal.java acf2f1d 
  exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java b390cd5 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/ExpressionTreeMaterializer.java
0f40958 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/FunctionImplementationRegistry.java
055fdfa 
  exec/java-exec/src/main/java/org/apache/drill/exec/server/DrillbitContext.java 165d5f3 
  exec/java-exec/src/main/java/org/apache/drill/exec/server/options/SystemOptionManager.java
34729e2 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/text/DrillTextRecordReader.java
e0cce8b 
  exec/java-exec/src/test/java/org/apache/drill/TestExampleQueries.java 30be58a 
  exec/java-exec/src/test/resources/emptyStrings.csv PRE-CREATION 

Diff: https://reviews.apache.org/r/29648/diff/


Testing
-------

unit tests,
functional tests,
tpch tests


Thanks,

Sean Hsuan-Yi Chu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message