Return-Path: X-Original-To: apmail-drill-dev-archive@www.apache.org Delivered-To: apmail-drill-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BE28510D84 for ; Fri, 5 Dec 2014 21:00:13 +0000 (UTC) Received: (qmail 98435 invoked by uid 500); 5 Dec 2014 21:00:12 -0000 Delivered-To: apmail-drill-dev-archive@drill.apache.org Received: (qmail 98381 invoked by uid 500); 5 Dec 2014 21:00:12 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 98333 invoked by uid 99); 5 Dec 2014 21:00:12 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Dec 2014 21:00:12 +0000 Date: Fri, 5 Dec 2014 21:00:12 +0000 (UTC) From: "Jacques Nadeau (JIRA)" To: dev@drill.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (DRILL-1812) SingleSender blocking rpc thread MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DRILL-1812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Nadeau resolved DRILL-1812. ----------------------------------- Resolution: Fixed Merged in d15ba12 > SingleSender blocking rpc thread > -------------------------------- > > Key: DRILL-1812 > URL: https://issues.apache.org/jira/browse/DRILL-1812 > Project: Apache Drill > Issue Type: Bug > Reporter: Steven Phillips > Assignee: Steven Phillips > Attachments: DRILL-1812.patch > > > When the send fails in SingleSender, the listener calls stop(), which creates two problems. First, stop() calls the cleanup() method, which can cause buffers to be removed while the execution thread is still using them. Second, this method blocks on waitForSendComlete(), and we never want to block the rpc thread, as this can lead to the drillbit becoming unresponsive. > The stop() method should not be called by thread other than the execution thread. -- This message was sent by Atlassian JIRA (v6.3.4#6332)