drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Parth Chandra" <pchan...@maprtech.com>
Subject Review Request 29064: DRILL-1869 - CPP Client does not handle record batches that contain nullable varchars with only null values.
Date Mon, 15 Dec 2014 22:21:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29064/
-----------------------------------------------------------

Review request for drill and Hanifi Gunes.


Repository: drill-git


Description
-------

CPP client asserts when the value vactor returned by the server contains only nulls because
the underlying sliced bytebuf class did not handle zero length buffers. Also in some cases
the server sends back an entire column with a value count of zero instead of a nullable vector.



Diffs
-----

  contrib/native/client/src/clientlib/recordBatch.cpp 2a679fa 
  contrib/native/client/src/include/drill/recordBatch.hpp 28377cb 
  contrib/native/client/src/protobuf/BitControl.pb.h 798da33 
  contrib/native/client/src/protobuf/BitControl.pb.cc 64ab783 
  contrib/native/client/src/protobuf/UserBitShared.pb.h cfe6938 
  contrib/native/client/src/protobuf/UserBitShared.pb.cc 17b3463 

Diff: https://reviews.apache.org/r/29064/diff/


Testing
-------


Thanks,

Parth Chandra


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message