drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Venkata krishnan Sowrirajan" <vsowrira...@maprtech.com>
Subject Re: Review Request 28496: DRILL-1779: Add unix_timestamp function
Date Thu, 04 Dec 2014 00:36:05 GMT


> On Dec. 4, 2014, 12:14 a.m., Kannan Rajah wrote:
> > exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestNewDateFunctions.java,
line 25
> > <https://reviews.apache.org/r/28496/diff/4/?file=782135#file782135line25>
> >
> >     Just curious as to why you switched to this new testBuilder way of writing unit
test.

It seems like we want to move to the new Unit test framework created as part of this JIRA
(DRILL-1458) which simplifies the Unit testing. Mehant, told me about this new framework and
we wanted to move all the test cases to this Unit test framework.


- Venkata krishnan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28496/#review63782
-----------------------------------------------------------


On Dec. 3, 2014, 11:17 p.m., Venkata krishnan Sowrirajan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28496/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2014, 11:17 p.m.)
> 
> 
> Review request for drill and Mehant Baid.
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> Added functionality for unix_timestamp() similar to MySQL
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/DateTypeFunctions.java
f063466 
>   exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestNewDateFunctions.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/28496/diff/
> 
> 
> Testing
> -------
> 
> Added testcases
> 
> 
> Thanks,
> 
> Venkata krishnan Sowrirajan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message