drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mehant Baid" <baid.meh...@gmail.com>
Subject Re: Review Request 28496: DRILL-1779: Add unix_timestamp function
Date Wed, 03 Dec 2014 23:55:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28496/#review63780
-----------------------------------------------------------

Ship it!


Looks good.

- Mehant Baid


On Dec. 3, 2014, 11:17 p.m., Venkata krishnan Sowrirajan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28496/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2014, 11:17 p.m.)
> 
> 
> Review request for drill and Mehant Baid.
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> Added functionality for unix_timestamp() similar to MySQL
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/DateTypeFunctions.java
f063466 
>   exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestNewDateFunctions.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/28496/diff/
> 
> 
> Testing
> -------
> 
> Added testcases
> 
> 
> Thanks,
> 
> Venkata krishnan Sowrirajan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message