drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kannan Rajah" <kra...@maprtech.com>
Subject Re: Review Request 28496: DRILL-1779: Add unix_timestamp function
Date Tue, 02 Dec 2014 01:37:08 GMT


> On Nov. 29, 2014, 2:58 a.m., Kannan Rajah wrote:
> > exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/DateTypeFunctions.java,
line 489
> > <https://reviews.apache.org/r/28496/diff/2/?file=777319#file777319line489>
> >
> >     Can we not just use the queryStartDate instead of creating a new date instance?
> 
> Venkata krishnan Sowrirajan wrote:
>     If I am not wrong, is this the fragment's queryStartTime("incoming.getContext().getQueryStartTime()")?
Like this instead of creating an instance of Date.

Yes. I think you can use that instead of creating a new object.


- Kannan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28496/#review63276
-----------------------------------------------------------


On Nov. 27, 2014, 8:16 a.m., Venkata krishnan Sowrirajan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28496/
> -----------------------------------------------------------
> 
> (Updated Nov. 27, 2014, 8:16 a.m.)
> 
> 
> Review request for drill and Mehant Baid.
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> Added functionality for unix_timestamp() similar to MySQL
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/DateTypeFunctions.java
f063466 
>   exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestDateFunctions.java 1ecae19

>   exec/java-exec/src/test/resources/functions/date/to_unixtimestamp_for_date.json PRE-CREATION

>   exec/java-exec/src/test/resources/functions/date/to_unixtimestamp_for_date_with_pattern.json
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/28496/diff/
> 
> 
> Testing
> -------
> 
> Added testcases
> 
> 
> Thanks,
> 
> Venkata krishnan Sowrirajan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message