Mailing-List: contact drill-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: drill-dev@incubator.apache.org
Content-Type: multipart/alternative;
 boundary="===============3064734855073476819=="
MIME-Version: 1.0
Subject: Re: Review Request 28417: DRILL-1742 Use Hive stats when planning
 queries on Hive data sources
From: "Aman Sinha" <asinha@maprtech.com>
To: "Aman Sinha" <asinha@maprtech.com>,
 "abdelhakim deneche" <adeneche@gmail.com>,
 "drill" <drill-dev@incubator.apache.org>
Date: Tue, 25 Nov 2014 00:12:54 -0000
Message-ID: <20141125001254.15977.55196@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Aman Sinha" <noreply@reviews.apache.org>
References: <20141124223300.15978.91592@reviews.apache.org>
In-Reply-To: <20141124223300.15978.91592@reviews.apache.org>
Reply-To: "Aman Sinha" <asinha@maprtech.com>

--===============3064734855073476819==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28417/#review62903
-----------------------------------------------------------


contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveScan.java
<https://reviews.apache.org/r/28417/#comment105055>

    This value is not initialized and only assigned to in the copy constructor (other 2 constructors are not doing anything with it).


contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveScan.java
<https://reviews.apache.org/r/28417/#comment105061>

    An assumption here is that the numRows property is always available...you should handle the scenario when it isn't.


contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveScan.java
<https://reviews.apache.org/r/28417/#comment105062>

    Same as above.


contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveScan.java
<https://reviews.apache.org/r/28417/#comment105058>

    Why does the estRowCount need to be here if it is not being used any more ?


contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveScan.java
<https://reviews.apache.org/r/28417/#comment105059>

    Why is the property NO_EXACT_ROW_COUNT if we are getting the exact row count from Hive ?


- Aman Sinha


On Nov. 24, 2014, 10:33 p.m., abdelhakim deneche wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28417/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2014, 10:33 p.m.)
> 
> 
> Review request for drill.
> 
> 
> Bugs: DRILL-1742
>     https://issues.apache.org/jira/browse/DRILL-1742
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> HiveScan.getSplits() already gets the table and partitions metadata using MetaStoreUtils.
> We compute the total number of rows using the numRows property and store the computed number of rows in rowCount attribute which is later returned by getScanStats().
> 
> 
> Diffs
> -----
> 
>   contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveScan.java ddbc100 
> 
> Diff: https://reviews.apache.org/r/28417/diff/
> 
> 
> Testing
> -------
> 
> created several partitioned and non-partitioned tables, loaded data in hive.
> 
> querying the tables I checked the logs to make sure the correct number of rows is computed.
> 
> 
> Thanks,
> 
> abdelhakim deneche
> 
>


--===============3064734855073476819==--