Return-Path: X-Original-To: apmail-incubator-drill-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-drill-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D0A7710252 for ; Wed, 19 Nov 2014 00:19:37 +0000 (UTC) Received: (qmail 82802 invoked by uid 500); 19 Nov 2014 00:19:37 -0000 Delivered-To: apmail-incubator-drill-dev-archive@incubator.apache.org Received: (qmail 82746 invoked by uid 500); 19 Nov 2014 00:19:37 -0000 Mailing-List: contact drill-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: drill-dev@incubator.apache.org Delivered-To: mailing list drill-dev@incubator.apache.org Received: (qmail 82732 invoked by uid 99); 19 Nov 2014 00:19:37 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Nov 2014 00:19:37 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 9AFEA116A99; Wed, 19 Nov 2014 00:19:36 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2815707016037767242==" MIME-Version: 1.0 Subject: Re: Review Request 26088: Drill 1458 unit test framework From: "Jason Altekruse" To: "Mehant Baid" Cc: "Jason Altekruse" , "drill" Date: Wed, 19 Nov 2014 00:19:36 -0000 Message-ID: <20141119001936.24716.95308@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Jason Altekruse" X-ReviewGroup: drill-git X-ReviewRequest-URL: https://reviews.apache.org/r/26088/ X-Sender: "Jason Altekruse" References: <20141119001239.24717.15886@reviews.apache.org> In-Reply-To: <20141119001239.24717.15886@reviews.apache.org> Reply-To: "Jason Altekruse" X-ReviewRequest-Repository: drill-git --===============2815707016037767242== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26088/#review62067 ----------------------------------------------------------- exec/java-exec/src/main/java/org/apache/drill/exec/store/ClassPathFileSystem.java This is a valid fix for the delimited text input format not working with the classpath storage plugin. I have moved it into a separate patch to just solve that issue, its filled as DRILL-1451. - Jason Altekruse On Nov. 19, 2014, 12:12 a.m., Jason Altekruse wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26088/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2014, 12:12 a.m.) > > > Review request for drill and Mehant Baid. > > > Repository: drill-git > > > Description > ------- > > new unit test framework to ease the process of creating unit tests with full result verification > > > Diffs > ----- > > common/src/main/java/org/apache/drill/common/types/Types.java 8ae3edd > exec/java-exec/src/main/resources/bootstrap-storage-plugins.json 4a20bea > exec/java-exec/src/test/java/org/apache/drill/BaseTestQuery.java 18fe84e > exec/java-exec/src/test/java/org/apache/drill/DrillTestWrapper.java PRE-CREATION > exec/java-exec/src/test/java/org/apache/drill/TestAltSortQueries.java 5768908 > exec/java-exec/src/test/java/org/apache/drill/TestBuilder.java PRE-CREATION > exec/java-exec/src/test/java/org/apache/drill/TestTestFramework.java PRE-CREATION > exec/java-exec/src/test/java/org/apache/drill/exec/HyperVectorValueIterator.java PRE-CREATION > exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java ac5673d > exec/java-exec/src/test/resources/sort/testSelectWithLimitOffset.tsv PRE-CREATION > exec/java-exec/src/test/resources/store/json/json_simple_with_null.json PRE-CREATION > exec/java-exec/src/test/resources/testframework/decimal_test.json PRE-CREATION > exec/java-exec/src/test/resources/testframework/decimal_test.tsv PRE-CREATION > exec/java-exec/src/test/resources/testframework/schema_change_int_to_string_non-matching.json PRE-CREATION > exec/java-exec/src/test/resources/testframework/small_test_data.json PRE-CREATION > exec/java-exec/src/test/resources/testframework/small_test_data.tsv PRE-CREATION > exec/java-exec/src/test/resources/testframework/small_test_data_extra.tsv PRE-CREATION > exec/java-exec/src/test/resources/testframework/small_test_data_extra_col.tsv PRE-CREATION > exec/java-exec/src/test/resources/testframework/small_test_data_reordered.tsv PRE-CREATION > exec/java-exec/src/test/resources/testframework/small_test_data_reordered_non_match_extra.tsv PRE-CREATION > exec/java-exec/src/test/resources/testframework/small_test_data_reordered_non_match_fewer.tsv PRE-CREATION > exec/java-exec/src/test/resources/vector/complex/fn/nested-with-nulls.json 7ce785c > pom.xml 26189fd > > Diff: https://reviews.apache.org/r/26088/diff/ > > > Testing > ------- > > Added both positive an negative unit test for varioud functionalities in the unit test framework. All previous unit tests are passing. > > > Thanks, > > Jason Altekruse > > --===============2815707016037767242==--