drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jacques Nadeau <jacq...@apache.org>
Subject Re: DRILL-1440
Date Fri, 07 Nov 2014 17:01:47 GMT
You need to provide a new complete diff on reviewboard.  You can't just add
a diff from the previous diff.

On Fri, Nov 7, 2014 at 8:21 AM, Jim Scott <jscott@maprtech.com> wrote:

> I attached the diff as a file to the review. I tried to attach it as an
> additional diff but it was erroring out, so I am not sure what the problem
> is with that, but the file is on the review.
>
> I did address the casts you referenced.
>
> On Thu, Nov 6, 2014 at 8:22 PM, Jacques Nadeau <jacques@apache.org> wrote:
>
> > It looks like you didn't address all the comments.  For example, one of
> the
> > comments I put there requests that you update your code so you don't do
> > repeated casts.  Did you forget to post your updated diff?
> >
> > On Mon, Nov 3, 2014 at 4:50 PM, Jim Scott <jscott@maprtech.com> wrote:
> >
> > > I have attached a patch to my review to address the open issues in the
> > > review: https://reviews.apache.org/r/25949/
> > >
> > > I attached the patch to the review. Not sure if that is the update
> > process
> > > or not.
> > >
> > > Jim
> > >
> > > --
> > > *Jim Scott*
> > > Director, Enterprise Strategy & Architecture
> > > +1 (347) 746-9281
> > >
> > >  <http://www.mapr.com/>
> > > [image: MapR Technologies] <http://www.mapr.com>
> > >
> >
>
>
>
> --
> *Jim Scott*
> Director, Enterprise Strategy & Architecture
> +1 (347) 746-9281
>
>  <http://www.mapr.com/>
> [image: MapR Technologies] <http://www.mapr.com>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message