drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "abdelhakim deneche" <adene...@gmail.com>
Subject Re: Review Request 28296: DRILL-1373 - Executing a query with a semi-colon as the last character causes 500 error in the query GUI
Date Fri, 28 Nov 2014 15:56:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28296/
-----------------------------------------------------------

(Updated Nov. 28, 2014, 3:56 p.m.)


Review request for drill.


Changes
-------

merged DRILL-1772 patch to this patch


Bugs: DRILL-1373
    https://issues.apache.org/jira/browse/DRILL-1373


Repository: drill-git


Description
-------

The problem with the /query page is that it doesn't display enough informations when an exception
occurs while processing the query. The proposed solution displays the exception message in
a new error page. This should help the user understand what's causing the error.
Of course, this patch assumes enough informations are available in the exception message.


Diffs (updated)
-----

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlWorker.java 863a6dc

  exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/QueryResources.java ba59d8f

  exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java 3e1393c 
  exec/java-exec/src/main/resources/rest/query/error.ftl PRE-CREATION 

Diff: https://reviews.apache.org/r/28296/diff/


Testing
-------


Thanks,

abdelhakim deneche


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message