drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steven Phillips" <sphill...@maprtech.com>
Subject Re: Review Request 28478: DRILL-1739: HAndle missing fields in complex parquet reader
Date Wed, 26 Nov 2014 22:31:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28478/#review63147
-----------------------------------------------------------

Ship it!


Ship It!

- Steven Phillips


On Nov. 26, 2014, 10:15 p.m., Parth Chandra wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28478/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2014, 10:15 p.m.)
> 
> 
> Review request for drill, Jason Altekruse and Steven Phillips.
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> The complex parquet reader does not handle the case where none of the fields specified
by the user are found in the schema and returns the entire set of fields.
> This review request includes the patch for DRILL-1738 as the first diff and patch for
DRILL-1739 as the second diff
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet2/DrillParquetGroupConverter.java
c6310b1 
>   exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet2/DrillParquetReader.java
c3e8330 
> 
> Diff: https://reviews.apache.org/r/28478/diff/
> 
> 
> Testing
> -------
> 
> Tested the following queries :
> 
> select not_found from dfs.`complex.parquet` d;
> select d.ingredients, not_found from dfs.`complex.parquet` d;
> 
> select not_found, d.ingredients.bag from dfs.`complex.parquet` d;
> 
> select not_found, d.ingredients.bag[0].name from dfs.`complex.parquet` d;
> 
> select d.recipe, d.not_found, d.ingredients.bag from dfs.`complex.parquet` d;
> select d.Recipe, d.not_found, d.ingredients.baG from dfs.`complex.parquet` d;
> select d.recipe, d.not_found, d.ingredients.bag, not_found_2 from dfs.`complex.parquet`
d;
> 
> 
> File Attachments
> ----------------
> 
> DRILL-1739
>   https://reviews.apache.org/media/uploaded/files/2014/11/26/492f2b39-cec8-4980-9141-926e5c796a59__patch0002.diff
> 
> 
> Thanks,
> 
> Parth Chandra
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message