drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Altekruse" <altekruseja...@gmail.com>
Subject Re: Review Request 26088: Drill 1458 unit test framework
Date Wed, 19 Nov 2014 00:12:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26088/
-----------------------------------------------------------

(Updated Nov. 19, 2014, 12:12 a.m.)


Review request for drill and Mehant Baid.


Changes
-------

Removed some TODOs that were finished or belong in JIRAs


Repository: drill-git


Description
-------

new unit test framework to ease the process of creating unit tests with full result verification


Diffs (updated)
-----

  common/src/main/java/org/apache/drill/common/types/Types.java 8ae3edd 
  exec/java-exec/src/main/resources/bootstrap-storage-plugins.json 4a20bea 
  exec/java-exec/src/test/java/org/apache/drill/BaseTestQuery.java 18fe84e 
  exec/java-exec/src/test/java/org/apache/drill/DrillTestWrapper.java PRE-CREATION 
  exec/java-exec/src/test/java/org/apache/drill/TestAltSortQueries.java 5768908 
  exec/java-exec/src/test/java/org/apache/drill/TestBuilder.java PRE-CREATION 
  exec/java-exec/src/test/java/org/apache/drill/TestTestFramework.java PRE-CREATION 
  exec/java-exec/src/test/java/org/apache/drill/exec/HyperVectorValueIterator.java PRE-CREATION

  exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java
ac5673d 
  exec/java-exec/src/test/resources/sort/testSelectWithLimitOffset.tsv PRE-CREATION 
  exec/java-exec/src/test/resources/store/json/json_simple_with_null.json PRE-CREATION 
  exec/java-exec/src/test/resources/testframework/decimal_test.json PRE-CREATION 
  exec/java-exec/src/test/resources/testframework/decimal_test.tsv PRE-CREATION 
  exec/java-exec/src/test/resources/testframework/schema_change_int_to_string_non-matching.json
PRE-CREATION 
  exec/java-exec/src/test/resources/testframework/small_test_data.json PRE-CREATION 
  exec/java-exec/src/test/resources/testframework/small_test_data.tsv PRE-CREATION 
  exec/java-exec/src/test/resources/testframework/small_test_data_extra.tsv PRE-CREATION 
  exec/java-exec/src/test/resources/testframework/small_test_data_extra_col.tsv PRE-CREATION

  exec/java-exec/src/test/resources/testframework/small_test_data_reordered.tsv PRE-CREATION

  exec/java-exec/src/test/resources/testframework/small_test_data_reordered_non_match_extra.tsv
PRE-CREATION 
  exec/java-exec/src/test/resources/testframework/small_test_data_reordered_non_match_fewer.tsv
PRE-CREATION 
  exec/java-exec/src/test/resources/vector/complex/fn/nested-with-nulls.json 7ce785c 
  pom.xml 26189fd 

Diff: https://reviews.apache.org/r/26088/diff/


Testing
-------

Added both positive an negative unit test for varioud functionalities in the unit test framework.
All previous unit tests are passing.


Thanks,

Jason Altekruse


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message