drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Barclay" <dbarc...@maprtech.com>
Subject Review Request 27711: To fix DRILL-1062, honoring "NULLS FIRST" and "NULLS LAST"
Date Fri, 14 Nov 2014 21:18:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27711/
-----------------------------------------------------------

Review request for drill, Jinfeng Ni and Mehant Baid.


Repository: drill-git


Description
-------

Main change:  Augmented *ordering* comparison function templates
and calls to to order NULL values correctly (per "NULLS FIRST",
"NULLS LAST", or correct default (depending on whether ordering is
ascending or descending)
*  Cloned each "compare_to" function template into 
   "compare_to_nulls_high" and "compare_to_nulls_low" versions
   and adjusted to handle NULL correctly.
*  Added corresponding new version of getComparator(...).
*  Updated code around calls to getComparator(...) re NULL ordering.
*  Added test class and test data files.


Diffs
-----

  .gitignore 838ea6b 
  common/src/main/java/org/apache/drill/common/logical/data/Order.java dada606 
  exec/java-exec/src/main/codegen/data/CompareTypes.tdd f384d52 
  exec/java-exec/src/main/codegen/templates/ComparisonFunctions.java 12f45b2 
  exec/java-exec/src/main/codegen/templates/DateIntervalFunctions.java 8fe13bb 
  exec/java-exec/src/main/codegen/templates/Decimal/CastVarCharDecimal.java acf2f1d 
  exec/java-exec/src/main/codegen/templates/Decimal/DecimalFunctions.java 0c4af01 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/annotations/FunctionTemplate.java
1f732a3 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/FunctionGenerationHelper.java
e0f7f93 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/ComparisonFunctions.java
bf42ce6 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/ComparisonFunctionsNullable.java
570aaeb 
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/TopN/TopNBatch.java 400a867

  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/StreamingAggBatch.java
17aaae8 
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/MergeJoinBatch.java
518971d 
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/mergereceiver/MergingRecordBatch.java
8da8f96 
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/orderedpartitioner/OrderedPartitionRecordBatch.java
a062074 
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/sort/SortBatch.java 19f5423

  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/window/StreamingWindowFrameRecordBatch.java
e0e9d42 
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/ExternalSortBatch.java
3f2692e 
  exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/QueryResultHandler.java 9015a16

  exec/jdbc/src/test/java/org/apache/drill/jdbc/test/JdbcNullOrderingAndGroupingTest.java
PRE-CREATION 
  exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestJdbcQuery.java b627c38 
  exec/jdbc/src/test/resources/donuts.json PRE-CREATION 
  exec/jdbc/src/test/resources/null_ordering_and_grouping_data.json PRE-CREATION 
  pom.xml 26189fd 

Diff: https://reviews.apache.org/r/27711/diff/


Testing
-------

Ran new fix-specific unit tests. 


Thanks,

Daniel Barclay


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message