drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yash Sharma" <yash...@gmail.com>
Subject Re: Review Request 24345: Drill-1141 - IsNumeric function review request
Date Wed, 12 Nov 2014 18:07:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24345/
-----------------------------------------------------------

(Updated Nov. 12, 2014, 6:07 p.m.)


Review request for drill, Aditya Kishore and Mehant Baid.


Changes
-------

Rebased Patch


Repository: drill-git


Description
-------

Implemented Drill Function IsNumeric for DRILL-1141


Diffs (updated)
-----

  exec/java-exec/src/main/codegen/data/NumericTypes.tdd f37a3dd 
  exec/java-exec/src/main/codegen/templates/NumericFunctionsTemplates.java PRE-CREATION 
  exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestNewMathFunctions.java f715747

  exec/java-exec/src/test/resources/functions/testIsNumericFunction.json PRE-CREATION 

Diff: https://reviews.apache.org/r/24345/diff/


Testing (updated)
-------

Yes.


Test Case:

 $mvn test -Dtest=TestNewMathFunctions#testIsNumeric

Sqlline Test:

0: jdbc:drill:zk=local> SELECT employee_id, isnumeric(employee_id) isnumeric_1, first_name,
isnumeric(first_name) isnumeric_2 FROM cp.`employee.json` limit 10; 

+-------------+-------------+------------+-------------+
| employee_id | isnumeric_1 | first_name | isnumeric_2 |
+-------------+-------------+------------+-------------+
| 1           | 1           | Sheri      | 0           |
| 2           | 1           | Derrick    | 0           |
| 4           | 1           | Michael    | 0           |
| 5           | 1           | Maya       | 0           |
| 6           | 1           | Roberta    | 0           |
| 7           | 1           | Rebecca    | 0           |
| 8           | 1           | Kim        | 0           |
| 9           | 1           | Brenda     | 0           |
| 10          | 1           | Darren     | 0           |
| 11          | 1           | Jonathan   | 0           |
+-------------+-------------+------------+-------------+
10 rows selected (0.451 seconds)


Thanks,

Yash Sharma


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message