drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hanifi Gunes" <hgu...@maprtech.com>
Subject Review Request 27844: DRILL-1455: enable projection pushdown past join
Date Mon, 10 Nov 2014 23:39:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27844/
-----------------------------------------------------------

Review request for drill, Aman Sinha and Jinfeng Ni.


Bugs: DRILL-1455
    https://issues.apache.org/jira/browse/DRILL-1455


Repository: drill-git


Description
-------

enable projection pushdown past join

i) refactor project past filter to remove redundant code
ii) adding unit tests for projection past join & hybrid cases like projection past filter
& join
iii) disable one TestExampleQueries#testSelectStartSubQueryJoinWithWhereClause until DRILL-1680
is fixed.


Diffs
-----

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillConditions.java
PRE-CREATION 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillPushProjectPastFilterRule.java
dcec68a 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillPushProjectPastJoinRule.java
PRE-CREATION 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillRuleSets.java 7af541a

  exec/java-exec/src/test/java/org/apache/drill/TestExampleQueries.java 9eaa20e 
  exec/java-exec/src/test/java/org/apache/drill/TestProjectPushDown.java 828ffe9 
  exec/java-exec/src/test/resources/project/pushdown/empty0.json PRE-CREATION 
  exec/java-exec/src/test/resources/project/pushdown/empty1.json PRE-CREATION 
  exec/java-exec/src/test/resources/project/pushdown/empty2.json PRE-CREATION 

Diff: https://reviews.apache.org/r/27844/diff/


Testing
-------

Passes tests.


Thanks,

Hanifi Gunes


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message