drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aditya Kishore" <adityakish...@gmail.com>
Subject Re: Review Request 27639: DRILL-1640: DrillColumnMetaDataList does not implement List methods
Date Thu, 06 Nov 2014 17:16:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27639/#review60184
-----------------------------------------------------------

Ship it!


Patch looks good with the minot nit.


exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillColumnMetaDataList.java
<https://reviews.apache.org/r/27639/#comment101519>

    nit:
    Please remove space after '(' and before ')' from all occurrence.


- Aditya Kishore


On Nov. 6, 2014, 7:41 a.m., Matt Burgess wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27639/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2014, 7:41 a.m.)
> 
> 
> Review request for drill.
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> DrillColumnMetaDataList does not implement much of the List interface (instead it throws
UnsupportedOperationExceptions), it should behave as a proper List
> 
> 
> Diffs
> -----
> 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillColumnMetaDataList.java 61afbfb

>   exec/jdbc/src/test/java/org/apache/drill/jdbc/DrillColumnMetaDataListTest.java PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/27639/diff/
> 
> 
> Testing
> -------
> 
> Patch provides implementation of List interface methods, as well as unit tests for constructor(s)
and all List interface methods not implemented by the superclass
> 
> 
> Thanks,
> 
> Matt Burgess
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message