drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matt Burgess" <mattyb...@gmail.com>
Subject Re: Review Request 27639: DRILL-1640: DrillColumnMetaDataList does not implement List methods
Date Thu, 06 Nov 2014 15:06:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27639/
-----------------------------------------------------------

(Updated Nov. 6, 2014, 3:06 p.m.)


Review request for drill.


Repository: drill-git


Description
-------

DrillColumnMetaDataList does not implement much of the List interface (instead it throws UnsupportedOperationExceptions),
it should behave as a proper List


Diffs
-----

  exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillColumnMetaDataList.java 61afbfb 
  exec/jdbc/src/test/java/org/apache/drill/jdbc/DrillColumnMetaDataListTest.java PRE-CREATION


Diff: https://reviews.apache.org/r/27639/diff/


Testing
-------

Patch provides implementation of List interface methods, as well as unit tests for constructor(s)
and all List interface methods not implemented by the superclass


File Attachments (updated)
----------------

Updated patch
  https://reviews.apache.org/media/uploaded/files/2014/11/06/7554d465-b6f2-4acb-827d-64ab34b61428__DRILL-1640.patch.2


Thanks,

Matt Burgess


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message