drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Scott" <...@13ways.com>
Subject Re: Review Request 25949: changes to support configuring text formats (field separator, record delimiter, quote character, header line, strip quotes)
Date Tue, 04 Nov 2014 00:38:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25949/
-----------------------------------------------------------

(Updated Nov. 3, 2014, 6:38 p.m.)


Review request for drill.


Repository: drill-git


Description
-------

Updates for handling text formatted files to address: https://issues.apache.org/jira/browse/DRILL-1440


Diffs
-----

  exec/java-exec/pom.xml 81dbeff 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/JsonRecordWriter.java
76c4ace 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/TextFormatPlugin.java
b64a032 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/text/DrillTextRecordReader.java
7b8761c 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/text/DrillTextRecordWriter.java
31b1fbe 
  exec/java-exec/src/test/java/org/apache/drill/exec/store/easy/text/TextFormatConfigTest.java
PRE-CREATION 

Diff: https://reviews.apache.org/r/25949/diff/


Testing
-------

There is a test class added to the serialization json work of the data formats including maintaing
backward compatibility as well as altering the field separator name.

Maven tests were run, with these two errors:
  TestWriter.simpleCsv » org.apache.drill.exec.rpc.RpcException: Failure while running fragment.
null [479d0e71-2bad-4f4c-b3fc-8bffc98f788b]
  TestWriter>BaseTestQuery.closeClient:125 » java.lang.IllegalStateException: Failure
while trying to close allocator: Child level allocators not closed.

I could not figure out the cause for these failures, nor could I properly debug why they were
occurring. The code in the patch should have no impact on those tests (although, I could be
wrong).


File Attachments (updated)
----------------

changes.diff
  https://reviews.apache.org/media/uploaded/files/2014/11/04/1e35fb1f-8646-4f10-b47f-647cbf3422c9__changes.diff


Thanks,

Jim Scott


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message