drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jinfeng Ni" <...@maprtech.com>
Subject Re: Review Request 27456: DRILL-1324: Add mechanism to detect schema changes
Date Mon, 03 Nov 2014 18:20:06 GMT


> On Nov. 3, 2014, 10:17 a.m., Jinfeng Ni wrote:
> > Ship It!

You may ask Steven to take a look how well this patch works with the "fast schema" feature.


- Jinfeng


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27456/#review59604
-----------------------------------------------------------


On Nov. 2, 2014, 9:47 p.m., Mehant Baid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27456/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2014, 9:47 p.m.)
> 
> 
> Review request for drill, Jinfeng Ni and Steven Phillips.
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> Currently we indicate a schema change only if the top level schema changes. However operators
would need to be aware of schema changes even if it occurs deep within a map vector. This
addresses this issue by adding a callback mechanism to indicate such a change has occurred.
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/codegen/templates/TypeHelper.java cb6a030 
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java ac65e40

>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java
486fb12 
>   exec/java-exec/src/main/java/org/apache/drill/exec/record/AbstractSingleRecordBatch.java
f6ae14f 
>   exec/java-exec/src/main/java/org/apache/drill/exec/record/VectorContainer.java 8e269b8

>   exec/java-exec/src/main/java/org/apache/drill/exec/util/CallBack.java PRE-CREATION

>   exec/java-exec/src/main/java/org/apache/drill/exec/vector/SchemaChangeCallBack.java
PRE-CREATION 
>   exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/AbstractContainerVector.java
096db6e 
>   exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/MapVector.java 1e4c8c4

>   exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedListVector.java
c75b359 
>   exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedMapVector.java
beb2475 
>   exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/impl/ComplexWriterImpl.java
920a4f3 
>   exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/impl/VectorContainerWriter.java
417d3ef 
>   exec/java-exec/src/test/java/org/apache/drill/exec/nested/TestNestedComplexSchema.java
1865120 
>   exec/java-exec/src/test/java/org/apache/drill/exec/vector/complex/writer/TestJsonReader.java
f207bba 
>   exec/java-exec/src/test/java/org/apache/drill/exec/vector/complex/writer/TestRepeated.java
a85a841 
>   exec/java-exec/src/test/resources/jsoninput/schemachangetest/a.json PRE-CREATION 
>   exec/java-exec/src/test/resources/jsoninput/schemachangetest/b.json PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/27456/diff/
> 
> 
> Testing
> -------
> 
> Added unit tests
> 
> 
> Thanks,
> 
> Mehant Baid
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message