drill-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From j..@apache.org
Subject [23/27] drill git commit: DRILL-5252: Fix a condition that always returns true
Date Thu, 02 Mar 2017 20:59:50 GMT
DRILL-5252: Fix a condition that always returns true

close #745


Project: http://git-wip-us.apache.org/repos/asf/drill/repo
Commit: http://git-wip-us.apache.org/repos/asf/drill/commit/33fc25ca
Tree: http://git-wip-us.apache.org/repos/asf/drill/tree/33fc25ca
Diff: http://git-wip-us.apache.org/repos/asf/drill/diff/33fc25ca

Branch: refs/heads/master
Commit: 33fc25ca2a4cd93fa40025f167f78655777ab47b
Parents: dcbcb94
Author: jc@lifove.net <jc@lifove.net>
Authored: Fri Feb 10 21:08:00 2017 -0500
Committer: Jinfeng Ni <jni@apache.org>
Committed: Wed Mar 1 23:46:24 2017 -0800

----------------------------------------------------------------------
 .../src/main/java/org/apache/drill/exec/expr/EqualityVisitor.java  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/drill/blob/33fc25ca/exec/java-exec/src/main/java/org/apache/drill/exec/expr/EqualityVisitor.java
----------------------------------------------------------------------
diff --git a/exec/java-exec/src/main/java/org/apache/drill/exec/expr/EqualityVisitor.java
b/exec/java-exec/src/main/java/org/apache/drill/exec/expr/EqualityVisitor.java
index 433e95f..5f79f32 100644
--- a/exec/java-exec/src/main/java/org/apache/drill/exec/expr/EqualityVisitor.java
+++ b/exec/java-exec/src/main/java/org/apache/drill/exec/expr/EqualityVisitor.java
@@ -290,7 +290,7 @@ class EqualityVisitor extends AbstractExprVisitor<Boolean,LogicalExpression,Runt
     if (!(value instanceof TypedNullConstant)) {
       return false;
     }
-    return e.getMajorType().equals(e.getMajorType());
+    return value.getMajorType().equals(e.getMajorType());
   }
 
   @Override


Mime
View raw message