Return-Path: <commits-return-4453-archive-asf-public=cust-asf.ponee.io@drill.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 29A98200C1F
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Sat,  4 Feb 2017 04:58:54 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id 284FD160B62; Sat,  4 Feb 2017 03:58:54 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 7AEF9160B6B
	for <archive-asf-public@cust-asf.ponee.io>; Sat,  4 Feb 2017 04:58:53 +0100 (CET)
Received: (qmail 9775 invoked by uid 500); 4 Feb 2017 03:58:52 -0000
Mailing-List: contact commits-help@drill.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:commits-help@drill.apache.org>
List-Unsubscribe: <mailto:commits-unsubscribe@drill.apache.org>
List-Post: <mailto:commits@drill.apache.org>
List-Id: <commits.drill.apache.org>
Reply-To: commits@drill.apache.org
Delivered-To: mailing list commits@drill.apache.org
Received: (qmail 9487 invoked by uid 99); 4 Feb 2017 03:58:51 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 04 Feb 2017 03:58:51 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 9C013F16C8; Sat,  4 Feb 2017 03:58:51 +0000 (UTC)
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
From: parthc@apache.org
To: commits@drill.apache.org
Date: Sat, 04 Feb 2017 03:58:58 -0000
Message-Id: <a1564de33922425489f8f1c128fd414e@git.apache.org>
In-Reply-To: <1e413bd842d640309b91a23afa65a58f@git.apache.org>
References: <1e413bd842d640309b91a23afa65a58f@git.apache.org>
X-Mailer: ASF-Git Admin Mailer
Subject: [8/8] drill git commit: DRILL-5240: Parquet - fix unnecessary object
 creation while checking for null values in nullable var length columns
archived-at: Sat, 04 Feb 2017 03:58:54 -0000

DRILL-5240: Parquet - fix unnecessary object creation while checking for null values in nullable var length columns

This closes #740


Project: http://git-wip-us.apache.org/repos/asf/drill/repo
Commit: http://git-wip-us.apache.org/repos/asf/drill/commit/ddcf8954
Tree: http://git-wip-us.apache.org/repos/asf/drill/tree/ddcf8954
Diff: http://git-wip-us.apache.org/repos/asf/drill/diff/ddcf8954

Branch: refs/heads/master
Commit: ddcf89548bd33c0cd3e062f1f6d5027eed822372
Parents: 1ec3edf
Author: Parth Chandra <pchandra@maprtech.com>
Authored: Wed Feb 1 20:14:52 2017 -0800
Committer: Parth Chandra <pchandra@maprtech.com>
Committed: Fri Feb 3 17:43:04 2017 -0800

----------------------------------------------------------------------
 .../store/parquet/columnreaders/NullableVarLengthValuesColumn.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/drill/blob/ddcf8954/exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/NullableVarLengthValuesColumn.java
----------------------------------------------------------------------
diff --git a/exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/NullableVarLengthValuesColumn.java b/exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/NullableVarLengthValuesColumn.java
index b18a81c..c96064b 100644
--- a/exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/NullableVarLengthValuesColumn.java
+++ b/exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/NullableVarLengthValuesColumn.java
@@ -122,7 +122,7 @@ public abstract class NullableVarLengthValuesColumn<V extends ValueVector> exten
   protected void readField(long recordsToRead) {
     // TODO - unlike most implementations of this method, the recordsReadInThisIteration field is not set here
     // should verify that this is not breaking anything
-    currentValNull = variableWidthVector.getAccessor().getObject(valuesReadInCurrentPass) == null;
+    currentValNull = variableWidthVector.getAccessor().isNull(valuesReadInCurrentPass);
     // again, I am re-purposing the unused field here, it is a length n BYTES, not bits
     if (! currentValNull) {
       if (usingDictionary) {