drill-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From par...@apache.org
Subject [8/8] drill git commit: DRILL-5240: Parquet - fix unnecessary object creation while checking for null values in nullable var length columns
Date Sat, 04 Feb 2017 03:58:58 GMT
DRILL-5240: Parquet - fix unnecessary object creation while checking for null values in nullable
var length columns

This closes #740


Project: http://git-wip-us.apache.org/repos/asf/drill/repo
Commit: http://git-wip-us.apache.org/repos/asf/drill/commit/ddcf8954
Tree: http://git-wip-us.apache.org/repos/asf/drill/tree/ddcf8954
Diff: http://git-wip-us.apache.org/repos/asf/drill/diff/ddcf8954

Branch: refs/heads/master
Commit: ddcf89548bd33c0cd3e062f1f6d5027eed822372
Parents: 1ec3edf
Author: Parth Chandra <pchandra@maprtech.com>
Authored: Wed Feb 1 20:14:52 2017 -0800
Committer: Parth Chandra <pchandra@maprtech.com>
Committed: Fri Feb 3 17:43:04 2017 -0800

----------------------------------------------------------------------
 .../store/parquet/columnreaders/NullableVarLengthValuesColumn.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/drill/blob/ddcf8954/exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/NullableVarLengthValuesColumn.java
----------------------------------------------------------------------
diff --git a/exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/NullableVarLengthValuesColumn.java
b/exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/NullableVarLengthValuesColumn.java
index b18a81c..c96064b 100644
--- a/exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/NullableVarLengthValuesColumn.java
+++ b/exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/NullableVarLengthValuesColumn.java
@@ -122,7 +122,7 @@ public abstract class NullableVarLengthValuesColumn<V extends ValueVector>
exten
   protected void readField(long recordsToRead) {
     // TODO - unlike most implementations of this method, the recordsReadInThisIteration
field is not set here
     // should verify that this is not breaking anything
-    currentValNull = variableWidthVector.getAccessor().getObject(valuesReadInCurrentPass)
== null;
+    currentValNull = variableWidthVector.getAccessor().isNull(valuesReadInCurrentPass);
     // again, I am re-purposing the unused field here, it is a length n BYTES, not bits
     if (! currentValNull) {
       if (usingDictionary) {


Mime
View raw message