drill-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s..@apache.org
Subject [1/3] drill git commit: DRILL-4182 Set type to LATE when values are nulls.
Date Wed, 20 Jan 2016 23:29:03 GMT
Repository: drill
Updated Branches:
  refs/heads/master 88ea7a25a -> 2f0e3f27e


DRILL-4182 Set type to LATE when values are nulls.


Project: http://git-wip-us.apache.org/repos/asf/drill/repo
Commit: http://git-wip-us.apache.org/repos/asf/drill/commit/717adcbb
Tree: http://git-wip-us.apache.org/repos/asf/drill/tree/717adcbb
Diff: http://git-wip-us.apache.org/repos/asf/drill/diff/717adcbb

Branch: refs/heads/master
Commit: 717adcbb8bd076224efb564feb3ac932a6b79fd9
Parents: 34bf45f
Author: Amit Hadke <amit.hadke@gmail.com>
Authored: Thu Dec 17 14:58:30 2015 -0800
Committer: Steven Phillips <steven@dremio.com>
Committed: Wed Jan 20 14:29:16 2016 -0800

----------------------------------------------------------------------
 .../src/main/java/org/apache/drill/exec/record/SchemaUtil.java     | 2 ++
 .../drill/exec/physical/impl/TopN/TestTopNSchemaChanges.java       | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/drill/blob/717adcbb/exec/java-exec/src/main/java/org/apache/drill/exec/record/SchemaUtil.java
----------------------------------------------------------------------
diff --git a/exec/java-exec/src/main/java/org/apache/drill/exec/record/SchemaUtil.java b/exec/java-exec/src/main/java/org/apache/drill/exec/record/SchemaUtil.java
index a9c9c96..e13e742 100644
--- a/exec/java-exec/src/main/java/org/apache/drill/exec/record/SchemaUtil.java
+++ b/exec/java-exec/src/main/java/org/apache/drill/exec/record/SchemaUtil.java
@@ -122,6 +122,8 @@ public class SchemaUtil {
         for (int i = 0; i < valueCount; i++) {
           if (!vv.getAccessor().isNull(i)) {
             u.getMutator().setType(i, type);
+          } else {
+            u.getMutator().setType(i, MinorType.LATE);
           }
         }
         for (MinorType t : field.getType().getSubTypeList()) {

http://git-wip-us.apache.org/repos/asf/drill/blob/717adcbb/exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TopN/TestTopNSchemaChanges.java
----------------------------------------------------------------------
diff --git a/exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TopN/TestTopNSchemaChanges.java
b/exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TopN/TestTopNSchemaChanges.java
index 8d78c9d..d5bb2d3 100644
--- a/exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TopN/TestTopNSchemaChanges.java
+++ b/exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TopN/TestTopNSchemaChanges.java
@@ -204,7 +204,7 @@ public class TestTopNSchemaChanges extends BaseTestQuery {
       .baselineValues(null, null, null, null, "200", "200")
       .baselineValues(null, null, null, null, "201", "201")
       .baselineValues(null, null, null, null, "202", "202");
-    //builder.go();
+    builder.go();
 
     // Since client can't handle new columns which are not in first batch, we won't test
output of query.
     // Query should run w/o any errors.


Mime
View raw message