drill-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From par...@apache.org
Subject drill git commit: DRILL-3096: Fixed logging in FragmentExecutor
Date Mon, 06 Jul 2015 21:49:54 GMT
Repository: drill
Updated Branches:
  refs/heads/master 2c13d793d -> 0a27a033a


DRILL-3096: Fixed logging in FragmentExecutor


Project: http://git-wip-us.apache.org/repos/asf/drill/repo
Commit: http://git-wip-us.apache.org/repos/asf/drill/commit/0a27a033
Tree: http://git-wip-us.apache.org/repos/asf/drill/tree/0a27a033
Diff: http://git-wip-us.apache.org/repos/asf/drill/diff/0a27a033

Branch: refs/heads/master
Commit: 0a27a033a349ba164e29d818a6ae73c41c0cd4bb
Parents: 2c13d79
Author: Sudheesh Katkam <skatkam@maprtech.com>
Authored: Wed Jul 1 14:28:47 2015 -0700
Committer: Parth Chandra <parthc@apache.org>
Committed: Mon Jul 6 14:48:31 2015 -0700

----------------------------------------------------------------------
 .../apache/drill/exec/work/fragment/FragmentExecutor.java    | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/drill/blob/0a27a033/exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentExecutor.java
----------------------------------------------------------------------
diff --git a/exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentExecutor.java
b/exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentExecutor.java
index 3409587..9eec782 100644
--- a/exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentExecutor.java
+++ b/exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentExecutor.java
@@ -353,18 +353,18 @@ public class FragmentExecutor implements Runnable {
   }
 
   private void warnStateChange(final FragmentState current, final FragmentState target) {
-    logger.warn("Ignoring unexpected state transition {} => {}.", current.name(), target.name());
+    logger.warn(fragmentName + ": Ignoring unexpected state transition {} --> {}", current.name(),
target.name());
   }
 
   private void errorStateChange(final FragmentState current, final FragmentState target)
{
-    final String msg = "Invalid state transition %s => %s.";
-    throw new StateTransitionException(String.format(msg, current.name(), target.name()));
+    final String msg = "%s: Invalid state transition %s --> %s";
+    throw new StateTransitionException(String.format(msg, fragmentName, current.name(), target.name()));
   }
 
   private synchronized boolean updateState(FragmentState target) {
     final FragmentHandle handle = fragmentContext.getHandle();
     final FragmentState current = fragmentState.get();
-    logger.info(fragmentName + ": State change requested from {} --> {} for ", current,
target);
+    logger.info(fragmentName + ": State change requested {} --> {}", current, target);
     switch (target) {
     case CANCELLATION_REQUESTED:
       switch (current) {


Mime
View raw message