distributedlog-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sijie <...@git.apache.org>
Subject [GitHub] incubator-distributedlog pull request #133: DL-124: Use Java8 Future rather ...
Date Mon, 19 Jun 2017 01:53:16 GMT
Github user sijie commented on a diff in the pull request:

    https://github.com/apache/incubator-distributedlog/pull/133#discussion_r122609664
  
    --- Diff: distributedlog-benchmark/conf/log4j.properties ---
    @@ -30,11 +30,7 @@ log4j.logger.org.apache.zookeeper=INFO
     log4j.logger.org.apache.bookkeeper=INFO
     
     # redirect executor output to executors.log since slow op warnings can be quite verbose
    -log4j.logger.org.apache.distributedlog.util.MonitoredFuturePool=INFO, Executors
    -log4j.logger.org.apache.distributedlog.util.MonitoredScheduledThreadPoolExecutor=INFO,
Executors
     log4j.logger.org.apache.bookkeeper.util.SafeRunnable=INFO, Executors
    -log4j.additivity.org.apache.distributedlog.util.MonitoredFuturePool=false
    --- End diff --
    
    MonitoredFuturePool and MonitoredScheduledThreadPoolExecutor are already removed in this
patch. because in Java8, you can configure a thread where the callbacks will be executed,
there is no need for additional future pool, we just use the ordered scheduler.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message