distributedlog-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DL-136) Avoid empty catch blocks
Date Tue, 20 Dec 2016 06:19:58 GMT

    [ https://issues.apache.org/jira/browse/DL-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15763387#comment-15763387
] 

ASF GitHub Bot commented on DL-136:
-----------------------------------

Github user sijie commented on the issue:

    https://github.com/apache/incubator-distributedlog/pull/74
  
    The change looks good to me +1 
    
    @brennonyork thank you for your contribution.


> Avoid empty catch blocks
> ------------------------
>
>                 Key: DL-136
>                 URL: https://issues.apache.org/jira/browse/DL-136
>             Project: DistributedLog
>          Issue Type: Task
>            Reporter: Sijie Guo
>            Assignee: Brennon York
>              Labels: help-wanted
>
> Based on the code analysis here : https://www.kiuwan.com/blog/analyzing_distributedlog_twitter-2/,
there are 22 Times: Catching exceptions with empty bodies.
> {quote}
> There are exceptions of different types: InterruptedException, KeeperException, Exception,
etc.. Even though we think that these exceptions should never occur, if they are captured
it means that they are technically possible. In case that they do happen, it will be very
difficult to know what is happening and to diagnose the problem. It is very recommendable,
at least to add a log trace, in case these exceptions are triggered.
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message