distributedlog-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DL-129) Enable check style for distributedlog-protocol module
Date Mon, 12 Dec 2016 19:58:58 GMT

    [ https://issues.apache.org/jira/browse/DL-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15742978#comment-15742978
] 

ASF GitHub Bot commented on DL-129:
-----------------------------------

Github user sijie commented on a diff in the pull request:

    https://github.com/apache/incubator-distributedlog/pull/54#discussion_r92025930
  
    --- Diff: distributedlog-build-tools/src/main/resources/distributedlog/checkstyle.xml
---
    @@ -0,0 +1,443 @@
    +<?xml version="1.0" encoding="UTF-8"?>
    +<!--
    +    Licensed to the Apache Software Foundation (ASF) under one or more
    +    contributor license agreements.  See the NOTICE file distributed with
    +    this work for additional information regarding copyright ownership.
    +    The ASF licenses this file to You under the Apache License, Version 2.0
    +    (the "License"); you may not use this file except in compliance with
    +    the License.  You may obtain a copy of the License at
    +
    +       http://www.apache.org/licenses/LICENSE-2.0
    +
    +    Unless required by applicable law or agreed to in writing, software
    +    distributed under the License is distributed on an "AS IS" BASIS,
    +    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +    See the License for the specific language governing permissions and
    +    limitations under the License.
    +-->
    +<!DOCTYPE module PUBLIC
    +    "-//Puppy Crawl//DTD Check Configuration 1.3//EN"
    +    "http://www.puppycrawl.com/dtds/configuration_1_3.dtd">
    +
    +<!-- This is a checkstyle configuration file. For descriptions of
    +what the following rules do, please see the checkstyle configuration
    +page at http://checkstyle.sourceforge.net/config.html -->
    +
    +<module name="Checker">
    +
    +  <module name="FileTabCharacter">
    +    <!-- Checks that there are no tab characters in the file. -->
    +  </module>
    +
    +  <module name="RegexpSingleline">
    +    <!-- Checks that TODOs don't have stuff in parenthesis, e.g., username. -->
    +    <property name="format" value="((//.*)|(\*.*))TODO\(" />
    --- End diff --
    
    it might be good to make sure there is a jira associated with TODO item?
    
    E.g. 
    
    "TODO: {@link jira_link}"?


> Enable check style for distributedlog-protocol module
> -----------------------------------------------------
>
>                 Key: DL-129
>                 URL: https://issues.apache.org/jira/browse/DL-129
>             Project: DistributedLog
>          Issue Type: Sub-task
>          Components: distributedlog-protocol
>            Reporter: Xi Liu
>            Assignee: Xi Liu
>             Fix For: 0.4.0
>
>
> Enable check style plugin for distributedlog-protocol module



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message