distributedlog-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DL-122) Use assertions from Junit rather than assert() for tests
Date Sun, 18 Dec 2016 16:30:58 GMT

    [ https://issues.apache.org/jira/browse/DL-122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15759066#comment-15759066
] 

ASF GitHub Bot commented on DL-122:
-----------------------------------

Github user sijie commented on the issue:

    https://github.com/apache/incubator-distributedlog/pull/77
  
    @brennonyork I think it is a common issue for a few tests that are kind of time dependent.
so travis ci will run two jobs and the apache jenkins will run another one. they run same
mvn command. if any of one passed the verification, it typically means that this change is
safe. so in your pull request, one of travis CI passed and the jenkins also passed, so your
change seems to be safe.


> Use assertions from Junit rather than assert() for tests
> --------------------------------------------------------
>
>                 Key: DL-122
>                 URL: https://issues.apache.org/jira/browse/DL-122
>             Project: DistributedLog
>          Issue Type: Bug
>          Components: distributedlog-core
>            Reporter: Gerrit Sundaram
>            Assignee: Brennon York
>
> there are too many places in test using 'assert()' rather than using assertions from
junit. it would be good that we can change that.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message