distributedlog-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sijie <...@git.apache.org>
Subject [GitHub] incubator-distributedlog pull request #37: Introduce namespace resolver for ...
Date Tue, 15 Nov 2016 09:51:59 GMT
Github user sijie commented on a diff in the pull request:

    https://github.com/apache/incubator-distributedlog/pull/37#discussion_r87980883
  
    --- Diff: distributedlog-core/src/main/java/com/twitter/distributedlog/BKDistributedLogNamespace.java
---
    @@ -470,6 +478,23 @@ private BKDistributedLogNamespace(
                     new Object[] { clientId, regionId, bkdlConfig.isFederatedNamespace()
});
         }
     
    +    /**
    +     * Validate the stream name.
    +     *
    +     * @param nameOfStream
    +     *          name of stream
    +     * @throws InvalidStreamNameException
    +     */
    +    private void validateName(String nameOfStream)
    +            throws InvalidStreamNameException {
    +        // validate the stream name
    +        nsResolver.validateStreamName(nameOfStream);
    +        if (isReservedStreamName(nameOfStream)) {
    --- End diff --
    
    shall we move the 'isReservedStreamName' validation to the resolver?
    
    or shall we just deprecate using '.' for any component name in the path?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message