distributedlog-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sijie <...@git.apache.org>
Subject [GitHub] incubator-distributedlog pull request #42: Fix deadlock on BKSyncLogReaderDL...
Date Tue, 15 Nov 2016 09:48:20 GMT
Github user sijie commented on a diff in the pull request:

    https://github.com/apache/incubator-distributedlog/pull/42#discussion_r87980394
  
    --- Diff: distributedlog-core/src/main/java/com/twitter/distributedlog/BKSyncLogReaderDLSN.java
---
    @@ -116,7 +110,7 @@ public void resumeReadAhead() {
     
         @Override
         public void onSuccess(LogRecordWithDLSN record) {
    -        setLastSeenDLSN(record.getDlsn());
    +        this.lastSeenDLSN = record.getDlsn();
    --- End diff --
    
    LGTM. @leighst what do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message