distributedlog-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DL-124) Use Java8 Future rather than twitter Future
Date Sat, 03 Jun 2017 10:53:05 GMT

    [ https://issues.apache.org/jira/browse/DL-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035930#comment-16035930
] 

ASF GitHub Bot commented on DL-124:
-----------------------------------

Github user jiazhai commented on a diff in the pull request:

    https://github.com/apache/incubator-distributedlog/pull/133#discussion_r119984456
  
    --- Diff: distributedlog-core/src/main/java/org/apache/distributedlog/BKAsyncLogReader.java
---
    @@ -381,16 +369,16 @@ public String getStreamName() {
          * @return A promise that when satisfied will contain the Log Record with its DLSN.
          */
         @Override
    -    public synchronized Future<LogRecordWithDLSN> readNext() {
    -        return readInternal(1, 0, TimeUnit.MILLISECONDS).map(READ_NEXT_MAP_FUNCTION);
    +    public synchronized CompletableFuture<LogRecordWithDLSN> readNext() {
    +        return readInternal(1, 0, TimeUnit.MILLISECONDS).thenApply(READ_NEXT_MAP_FUNCTION);
         }
     
    -    public synchronized Future<List<LogRecordWithDLSN>> readBulk(int numEntries)
{
    +    public synchronized CompletableFuture<List<LogRecordWithDLSN>> readBulk(int
numEntries) {
             return readInternal(numEntries, 0, TimeUnit.MILLISECONDS);
         }
     
         @Override
    -    public synchronized Future<List<LogRecordWithDLSN>> readBulk(int numEntries,
    +    public synchronized CompletableFuture<List<LogRecordWithDLSN>> readBulk(int
numEntries,
                                                                      long waitTime,
    --- End diff --
    
    Please also do the code alignment change here.


> Use Java8 Future rather than twitter Future
> -------------------------------------------
>
>                 Key: DL-124
>                 URL: https://issues.apache.org/jira/browse/DL-124
>             Project: DistributedLog
>          Issue Type: Bug
>    Affects Versions: 0.4.0
>            Reporter: Gerrit Sundaram
>            Assignee: Sijie Guo
>              Labels: help-wanted
>             Fix For: 0.5.0
>
>
> Since it is written in java, it would be good to leverage java8 future rather than introducing
dependencies on scala.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message