distributedlog-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DL-124) Use Java8 Future rather than twitter Future
Date Fri, 02 Jun 2017 23:49:04 GMT

    [ https://issues.apache.org/jira/browse/DL-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035637#comment-16035637
] 

ASF GitHub Bot commented on DL-124:
-----------------------------------

GitHub user sijie opened a pull request:

    https://github.com/apache/incubator-distributedlog/pull/133

    DL-124: Use Java8 Future rather than twitter Future

    Switch to use Java8 CompletableFuture, to reduce dependencies introduced by twitter future
and make it more friendly to users (users don't think of using which version of scala).
    
    This change is based on #132 . Gitsha ce0686e is the change to review.
    
    The changes:
    
    - Change Future to CompletableFuture
    - Map to thenApply
    - flatMap to thenCompose
    - Added a FutureEventListener, and switch addEvenListener to whenComplete (or whenCompleteAsync)
    - setValue to complete
    - setException to completeExceptionally
    - add rescue, ignore, ensure to FutureUtils as util functions.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sijie/incubator-distributedlog change_twitter_future_to_java_future

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-distributedlog/pull/133.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #133
    
----
commit 54c2de047e1656e34ead7fb54070441afd9c140d
Author: Sijie Guo <sijie@apache.org>
Date:   2017-05-26T22:05:43Z

    Re-organize the distributedlog modules
    
    - move proxy related class from protocol to proxy-protocol, changed client and service
to proxy-client and proxy-service

commit 67e76150b103422f16883857a1c1345cf044fb45
Author: Sijie Guo <sijie@apache.org>
Date:   2017-05-27T07:04:40Z

    Use integration for exception code rather than thrift generated StatusCode

commit 6e587869f87cdce50ae93ba3d52767719d1ab5a6
Author: Sijie Guo <sijie@apache.org>
Date:   2017-05-27T07:34:02Z

    Use the latest thrift version for distributedlog-core and remove scrooge

commit ce0686e30e89c75ffce81473de5a0264d5d95f58
Author: Sijie Guo <sijie@apache.org>
Date:   2017-05-29T23:06:19Z

    Change Twitter Future to Java8 CompletableFuture

----


> Use Java8 Future rather than twitter Future
> -------------------------------------------
>
>                 Key: DL-124
>                 URL: https://issues.apache.org/jira/browse/DL-124
>             Project: DistributedLog
>          Issue Type: Bug
>    Affects Versions: 0.4.0
>            Reporter: Gerrit Sundaram
>            Assignee: Sijie Guo
>              Labels: help-wanted
>             Fix For: 0.5.0
>
>
> Since it is written in java, it would be good to leverage java8 future rather than introducing
dependencies on scala.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message