distributedlog-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DL-204) Bump libthrift to latest version for distributedlog-core
Date Tue, 30 May 2017 09:13:04 GMT

    [ https://issues.apache.org/jira/browse/DL-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16029196#comment-16029196
] 

ASF GitHub Bot commented on DL-204:
-----------------------------------

GitHub user sijie opened a pull request:

    https://github.com/apache/incubator-distributedlog/pull/132

    DL-204: Bump libthrift to latest version for distributedlog-core

    Currently finagle heavily depends on an out-of-dated version - libthrift 5.0. Proxy modules
(client, server) depend on this version, however the core library doesn't really depend on
libthrift. 
    
    This change is to change libthrift to 0.9.* in distributedlog-core and shade it to avoid
it conflict with the version used by finagle.
    
    This change is based on #131 . The main change is at gitsha [6e58786](https://github.com/apache/incubator-distributedlog/commit/6e587869f87cdce50ae93ba3d52767719d1ab5a6)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sijie/incubator-distributedlog change_thrift_for_core_module

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-distributedlog/pull/132.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #132
    
----
commit 54c2de047e1656e34ead7fb54070441afd9c140d
Author: Sijie Guo <sijie@apache.org>
Date:   2017-05-26T22:05:43Z

    Re-organize the distributedlog modules
    
    - move proxy related class from protocol to proxy-protocol, changed client and service
to proxy-client and proxy-service

commit 67e76150b103422f16883857a1c1345cf044fb45
Author: Sijie Guo <sijie@apache.org>
Date:   2017-05-27T07:04:40Z

    Use integration for exception code rather than thrift generated StatusCode

commit 6e587869f87cdce50ae93ba3d52767719d1ab5a6
Author: Sijie Guo <sijie@apache.org>
Date:   2017-05-27T07:34:02Z

    Use the latest thrift version for distributedlog-core and remove scrooge

commit 03b2abd7bb97d4ca996e51329be3fcc485299416
Author: Sijie Guo <sijie@apache.org>
Date:   2017-05-30T08:39:19Z

    Fix the testcase related to status code change in exceptions

commit 104ee6f2e496316eee992d0269428924a6028c19
Author: Sijie Guo <sijie@apache.org>
Date:   2017-05-30T08:44:18Z

    Merge branch 'new_layout' into change_thrift_for_core_module

commit 40cdaadaf25d8ad3df3263e71dd97ad68ed62145
Author: Sijie Guo <sijie@apache.org>
Date:   2017-05-30T09:08:07Z

    fix module name

----


> Bump libthrift to latest version for distributedlog-core
> --------------------------------------------------------
>
>                 Key: DL-204
>                 URL: https://issues.apache.org/jira/browse/DL-204
>             Project: DistributedLog
>          Issue Type: Improvement
>    Affects Versions: 0.4.0
>            Reporter: Sijie Guo
>            Assignee: Sijie Guo
>             Fix For: 0.5.0
>
>
> Currently finagle heavily depends on an out-of-dated version - libthrift 5.0. Proxy modules
(client, server) depend on this version, however the core library doesn't really depend on
libthrift. so this jira is to bump libthrift version for distributedlog-core.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message